New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix showing announcement when comments are disabled #12558
Open
andreslucena
wants to merge
8
commits into
develop
Choose a base branch
from
fix/comments-disabled-announcement
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
changed the title
Fix showing announcement when comments are disabled
Fix showing announcement when comments are disabled
Mar 4, 2024
andreslucena
force-pushed
the
fix/comments-disabled-announcement
branch
from
March 4, 2024 18:17
6949757
to
5566b02
Compare
andreslucena
force-pushed
the
fix/comments-disabled-announcement
branch
from
March 12, 2024 14:37
3924842
to
b6244d5
Compare
This is done mainly because some modules (such as Initiatives) don't have the feature for blocking the comments in the steps (as they don't have steps as a Participatory Process)
andreslucena
force-pushed
the
fix/comments-disabled-announcement
branch
from
May 22, 2024 14:06
8c16369
to
2930d3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
configuration
module: accountability
module: blogs
module: budgets
module: comments
module: core
module: debates
module: dev
module: meetings
module: proposals
type: fix
PRs that implement a fix for a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
There's no warning message for disabled comments in frontend. This PR adds it.
馃搶 Related Issues
Testing
馃摲 Screenshots