Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilingual organization name #12681

Merged
merged 41 commits into from May 21, 2024
Merged

Multilingual organization name #12681

merged 41 commits into from May 21, 2024

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Apr 10, 2024 •
edited

🎩 What? Why?

This PR adds support of internationalized organization name.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit the organization settings of an admin
  2. See there is only one field for the organization.
  3. Apply patch, run migrations and see that you have a language selector for organization name
  4. Fill in that with some results ( ex: European Commission + some translations )
  5. Save and navigate website
  6. Change the current locale and see that the organization name is being translated.
  7. Check the admin panel.

📷 Screenshots

Please add screenshots of the changes you are proposing
image

image

image
image
image

♥️ Thank you!

github-actions[bot]
github-actions bot requested changes Apr 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupu alecslupu added the type: change PRs that implement a change for an existing feature label Apr 24, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 24, 2024
View reviewed changes
@alecslupu alecslupu requested a review from a team April 24, 2024 15:08
@alecslupu alecslupu marked this pull request as ready for review April 24, 2024 15:09
github-actions[bot]
github-actions bot previously approved these changes Apr 24, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
View reviewed changes
@alecslupu
Copy link
Contributor Author

@andreslucena , this is ready for a new review

andreslucena
andreslucena requested changes May 16, 2024
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two comments in the last file to be "viewed" and we're ready for the merge 🚀

decidim-system/app/forms/decidim/system/update_organization_form.rb Show resolved Hide resolved
decidim-system/app/forms/decidim/system/update_organization_form.rb Show resolved Hide resolved
@alecslupu @andreslucena
Update decidim-system/app/forms/decidim/system/update_organization_fo…
c984a89 
…rm.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
View reviewed changes
@andreslucena andreslucena merged commit cb466cb into decidim:develop May 21, 2024
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees

@andreslucena andreslucena

Labels
module: admin module: api module: blogs module: budgets module: conferences module: core type: change PRs that implement a change for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multilingual organization name
2 participants
@alecslupu @andreslucena