Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor malformed titles in admin logs #12702

Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Apr 17, 2024

🎩 What? Why?

This PR tries to fix some display issues in the admin logs area.
It also:

  • fixes a bug, when the admin logs displays the View diff button even though no diff is needed ( pic 1).
  • Removes the code duplication with regards to admin resource logs.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Make sure everything is green.

📷 Screenshots

image

Classes to handle

  • ./decidim-accountability/app/presenters/decidim/accountability/admin_log/timeline_entry_presenter.rb
  • ./decidim-accountability/app/presenters/decidim/accountability/admin_log/status_presenter.rb
  • ./decidim-accountability/app/presenters/decidim/accountability/admin_log/result_presenter.rb
  • ./decidim-assemblies/app/presenters/decidim/assemblies/admin_log/assembly_member_presenter.rb
  • ./decidim-assemblies/app/presenters/decidim/assemblies/admin_log/assembly_presenter.rb
  • ./decidim-assemblies/app/presenters/decidim/assemblies/admin_log/assemblies_type_presenter.rb
  • ./decidim-assemblies/app/presenters/decidim/assemblies/admin_log/assembly_user_role_presenter.rb
  • ./decidim-blogs/app/presenters/decidim/blogs/admin_log/post_presenter.rb
  • ./decidim-budgets/app/presenters/decidim/budgets/admin_log/project_presenter.rb
  • ./decidim-budgets/app/presenters/decidim/budgets/admin_log/budget_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/conference_speaker_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/conference_user_role_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/partner_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/media_link_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/conference_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/registration_type_presenter.rb
  • ./decidim-conferences/app/presenters/decidim/conferences/admin_log/conference_registration_presenter.rb
  • ./decidim-core/app/presenters/decidim/log/base_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/organization_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/moderation_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/attachment_collection_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/area_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/oauth_application_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/component_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/participatory_space_private_user_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/static_page_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/category_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/area_type_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/scope_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/newsletter_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/scope_type_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/user_moderation_presenter.rb
  • ./decidim-core/app/presenters/decidim/admin_log/contextual_help_section_presenter.rb
  • ./decidim-debates/app/presenters/decidim/debates/admin_log/debate_presenter.rb
  • ./decidim-initiatives/app/presenters/decidim/initiatives/admin_log/initiatives_type_presenter.rb
  • ./decidim-initiatives/app/presenters/decidim/initiatives/admin_log/initiative_presenter.rb
  • ./decidim-meetings/app/presenters/decidim/meetings/admin_log/meeting_presenter.rb
  • ./decidim-pages/app/presenters/decidim/pages/admin_log/page_presenter.rb
  • ./decidim-participatory_processes/app/presenters/decidim/participatory_processes/admin_log/step_presenter.rb
  • ./decidim-participatory_processes/app/presenters/decidim/participatory_processes/admin_log/participatory_process_type_presenter.rb
  • ./decidim-participatory_processes/app/presenters/decidim/participatory_processes/admin_log/participatory_process_user_role_presenter.rb
  • ./decidim-participatory_processes/app/presenters/decidim/participatory_processes/admin_log/participatory_process_group_presenter.rb
  • ./decidim-participatory_processes/app/presenters/decidim/participatory_processes/admin_log/participatory_process_presenter.rb
  • ./decidim-proposals/app/presenters/decidim/proposals/admin_log/proposal_note_presenter.rb
  • ./decidim-proposals/app/presenters/decidim/proposals/admin_log/proposal_state_presenter.rb
  • ./decidim-proposals/app/presenters/decidim/proposals/admin_log/valuation_assignment_presenter.rb
  • ./decidim-proposals/app/presenters/decidim/proposals/admin_log/proposal_presenter.rb
  • ./decidim-sortitions/app/presenters/decidim/sortitions/admin_log/sortition_presenter.rb
  • ./decidim-templates/app/presenters/decidim/templates/admin_log/template_presenter.rb

♥️ Thank you!

@alecslupu alecslupu added the type: fix PRs that implement a fix for a bug label Apr 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 17, 2024
github-actions[bot]
github-actions bot previously approved these changes Apr 17, 2024
@alecslupu alecslupu requested a review from a team April 17, 2024 15:00
@alecslupu alecslupu marked this pull request as ready for review April 17, 2024 15:00
@andreslucena andreslucena changed the title Refactor Admin Logs Refactor malformed titles in admin logs Apr 18, 2024
@andreslucena
Copy link
Member

@alecslupu I understand that do we need to check all those presenters?

@alecslupu
Copy link
Contributor Author

@alecslupu I understand that do we need to check all those presenters?

@andreslucena , yes. This is a list with the specs that i need to add in order to make sure that we fix the issue for the existing presenters.

@alecslupu alecslupu marked this pull request as draft April 24, 2024 09:17
github-actions[bot]
github-actions bot previously approved these changes May 14, 2024
github-actions[bot]
github-actions bot previously approved these changes May 17, 2024
github-actions[bot]
github-actions bot previously approved these changes May 19, 2024
github-actions[bot]
github-actions bot previously approved these changes May 19, 2024
github-actions[bot]
github-actions bot previously approved these changes May 19, 2024
@probot-autolabeler probot-autolabeler bot added javascript Pull requests that update Javascript code module: admin labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants