Load the Leaflet assets through the NPM packages #12762
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of shipping the Leaflet assets in Decidim and making them harder to update, load them directly from the NPM packages.
ahukkanen
added
module: core
type: change
As these are now loaded directly from the NPM package.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Noticed at #12747 that the Leaflet CSS is shipped within the Decidim code which makes it hard to update. Instead of shipping the Leaflet assets in Decidim we can load them directly from the NPM packages.
The issue noted at the
map.scsscomment can be solved by simply adding the Leaflet path to the module resolve paths.馃搶 Related Issues
Testing