Hide moderated content from notifications #12829
Open
+152
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
andreslucena
requested changes
May 23, 2024
decidim-accountability/spec/events/decidim/accountability/proposal_linked_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-accountability/spec/events/decidim/accountability/result_progress_updated_event_spec.rb
Outdated
Show resolved
Hide resolved
decidim-comments/lib/decidim/comments/test/shared_examples/comment_event.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Just to confirm it, but we can't show the date when it was moderated so it's consistent with the message in the comment page, right? (i.e. "Comment moderated on 23/05/2024 11:05")
There was a problem hiding this comment.
As i have previously stated, we cannot display that information, or at this moment i do not see how to do it.
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR attempts to hide the moderated content from the notifications block. I have noticed that the moderated content is still being available in the notifications even though the content itself has been moderated. I have noticed that a while ago in MetaDecidim.
This PR adds a simple "Content moderated" string instead of actual notification, just to preserve the pagination integrity. It does not add any "Content moderated on %{date}" as we have on comments, because we do not have a very good grasp of the resource that is being hidden. Sometimes, the hidden content can be a comment, but sometimes it could be the resource commentable.
📌 Related Issues
Link your PR to an issue
Testing
📷 Screenshots
Please add screenshots of the changes you are proposing
A comment being moderated
A resource being moderated ( that also have comments associated: 1 meeting + 4 comments associated )
