Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise current_user call within Commands tasks (Participatory Processes) #12840

Conversation

greenwoodt
Copy link
Contributor

@greenwoodt greenwoodt commented May 7, 2024

🎩 What? Why?

current_user call is standardized/refactored within the specific tasks of various Classes in the Participatory Processes module.

📌 Related Issues

Testing

run decidim-participatory_processes/spec/commands/copy_participatory_process_spec.rb

📷 Screenshots

♥️ Thank you!

@greenwoodt greenwoodt added module: participatory processes type: change PRs that implement a change for an existing feature labels May 7, 2024
github-actions[bot]
github-actions bot previously approved these changes May 7, 2024
github-actions[bot]
github-actions bot previously approved these changes May 7, 2024
github-actions[bot]
github-actions bot previously approved these changes May 7, 2024
github-actions[bot]
github-actions bot previously approved these changes May 8, 2024
github-actions[bot]
github-actions bot previously approved these changes May 8, 2024
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a another place where to change this:

decidim-participatory_processes/app/commands/decidim/participatory_processes/admin/import_participatory_process.rb

Can you change it there 🙏🏽 ?

@greenwoodt
Copy link
Contributor Author

I think I found a another place where to change this:

decidim-participatory_processes/app/commands/decidim/participatory_processes/admin/import_participatory_process.rb

Can you change it there 🙏🏽 ?

Can the current_user be standardised here?

@andreslucena
Copy link
Member

Can the current_user be standardised here?

Yes, we're calling form.current_user and we could call to current_user if we add the delegation.

github-actions[bot]
github-actions bot previously approved these changes May 10, 2024
github-actions[bot]
github-actions bot previously approved these changes May 10, 2024
github-actions[bot]
github-actions bot previously approved these changes May 15, 2024
…ipatory_processes/admin/participatory_process_copies_controller.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
@greenwoodt greenwoodt changed the title Standardise current_user call within Commands tasks (Participatory Processes) Standardise current_user call within Commands tasks (Participatory Processes) May 16, 2024
github-actions[bot]
github-actions bot previously approved these changes May 16, 2024
…ipatory_processes/admin/participatory_process_copies_controller.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@andreslucena andreslucena changed the title Standardise current_user call within Commands tasks (Participatory Processes) Standardise current_user call within Commands tasks (Participatory Processes) May 22, 2024
@andreslucena andreslucena merged commit 351b8a4 into decidim:develop May 22, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: participatory processes type: change PRs that implement a change for an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants