Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove similar initiatives logic and PreviousForm class leftovers #12841

Merged
merged 2 commits into from May 15, 2024

Conversation

andreslucena
Copy link
Member

馃帺 What? Why?

While reviewing the codebase, I found a couple leftovers in decidim-initiatives:

  • SimilarInitiatives class and config_accessors
  • PreviousForm

the similar initiatives step was removed in

馃搶 Related Issues

  • Related to Decidim frontend redesign聽#11122 (or at least that's what it seems by skimming the history of decidim-initiatives/app/controllers/decidim/initiatives/create_initiative_controller.rb)

Testing

Every check in the CI should be green 馃挌

鈾ワ笍 Thank you!

@andreslucena andreslucena added the type: removal PRs that implement a removal of a functionality or code label May 9, 2024
Copy link
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@alecslupu alecslupu merged commit 6fe467f into develop May 15, 2024
46 of 47 checks passed
@alecslupu alecslupu deleted the removal/similar-initiatives branch May 15, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: initiatives type: removal PRs that implement a removal of a functionality or code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants