feat!: Remove eslint-plugin-prettier #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndKiel
requested review from
andrei-bitca-dc,
ali-habibzadeh,
Nikamura and
rprovodenko
Nikamura
approved these changes
May 26, 2020
andrei-bitca-dc
approved these changes
May 26, 2020
AndKiel
added a commit
that referenced
this pull request
May 27, 2020
BREAKING CHANGE: Prettier is removed from eslint configuration and required to be run separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes summary
This PR contains changes from #6 - merge base is set to
feat/upgrade-ts-eslintso only relevant changes are visible.Prettier is removed from linting to speed up the whole process.
canary test run results
Upgrade preview: https://github.com/deepcrawl/canary/compare/style/eslint-config...style/eslint-prettier?expand=1
yarn lint:check packages/graph-apiyarn lintNo attempt was made to lint the whole repository with
prettierenabled. In the past it proved impossible, the process running out of memory or hanging and never finishing (waited up to 20 minutes).After the changes
huskypre-commit hooks are working faster. Additionally, they do not crash in SourceTree.