[Controller] parse kvm support run.xml #6022
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askyrie
force-pushed
the
parse_kvm_support_run_xml
branch
7 times, most recently
from
2ffb03b
to
c1ba789
Compare
askyrie
force-pushed
the
parse_kvm_support_run_xml
branch
from
c1ba789
to
806f5c5
Compare
sharang
reviewed
Apr 10, 2024
| ## 可通过此配置将虚拟机名称指定为 domain.name、domain.title、domain.uuid 之一，默认为空 | ||
| ## 当使用此配置指定的字段取不到虚拟机名称或虚拟机名称为空时，则将使用 domain.name 的值作为虚拟机名称 | ||
| ## 例：vm_name_field: title ，指定 domain.title 作为虚拟机的名称 | ||
| #vm_name_field: "" |
There was a problem hiding this comment.
domian.metadata.instance.name ？
sharang
reviewed
Apr 10, 2024
| @@ -292,6 +292,12 @@ controller: | |||
| # 忽略网卡正则表达式配置，匹配到会忽略该网卡，默认为 ^(kube-ipvs) ，增加其他的网卡名称需要在此基础上新增 | |||
| ignore_nic_regex: | |||
|
|
|||
| ## 采集器同步 KVM ，解析虚拟机的 XML 时，默认使用 domian.metadata.instance.name 字段作为虚拟机的名称 | |||
| ## 可通过此配置将虚拟机名称指定为 domain.name、domain.title、domain.uuid 之一，默认为空 | |||
There was a problem hiding this comment.
默认为空改掉。
默认肯定有个行为，比如是 domain.name ？
sharang
reviewed
Apr 10, 2024
| @@ -27,4 +27,5 @@ type GenesisConfig struct { | |||
| MultiNSMode bool `default:"false" yaml:"multi_ns_mode"` | |||
| SingleVPCMode bool `default:"false" yaml:"single_vpc_mode"` | |||
| IgnoreNICRegex string `default:"^(kube-ipvs)" yaml:"ignore_nic_regex"` | |||
| VMNameField string `default:"" yaml:"vm_name_field"` | |||
There was a problem hiding this comment.
这个 config 读取之后应该有一个 validate 的过程。在 validate 中就将 default 值设置上去（发现是空的时候）。
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for: