New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to lerna v6 #1011
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
=======================================
Coverage 41.94% 41.94%
=======================================
Files 430 430
Lines 32475 32475
Branches 8177 8177
=======================================
Hits 13622 13622
Misses 18800 18800
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like npm start
doesn't work anymore - something happen with the vite proxy?
For now, I've disabled nx until nrwl/nx#14010 is fixed An alternative would be to change our The proxy is broken though if you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we're still checking in the nx.json
file even if we're not using it yet so we don't have to rebuild later?
Ya that's what I was thinking since it took some work to properly put together. There's 1 option that allows us to use nx in its current state which is to change |
Changed type to
It could be
|
Fixes #864
Lerna v6 comes w/ nx by default. I've setup the caching for build tasks so builds should be faster/cached locally when possible.
test
could be cached (see here), but we run it in watch mode usually so doesn't make as much sense.Running
npm run build
twice in a row should result in the 2nd time taking 1 second or so to cache-hit everything. You can runnpm run clean:build
and thennpm run build
again and it will only take a few seconds to restore the output from the cache.npm run clean
also cleans the nx cache.