Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SampleSection component to conditionally render based on route #2000

Merged
merged 9 commits into from
May 23, 2024

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented May 9, 2024

SampleSection component is now responsible for rendering / not rendering based on route. Contrast to before where we rendered everything and then hid via css.

Seems to cut time to run styleguide tests by more than half locally.

image

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.37%. Comparing base (c9ac72d) to head (11df9d4).

Current head 11df9d4 differs from pull request most recent head 58a2a63

Please upload reports for the commit 58a2a63 to get more accurate results.

Files Patch % Lines
...kages/code-studio/src/styleguide/SampleSection.tsx 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2000      +/-   ##
==========================================
+ Coverage   46.35%   46.37%   +0.02%     
==========================================
  Files         670      669       -1     
  Lines       38735    38713      -22     
  Branches     9806     9807       +1     
==========================================
  Hits        17955    17955              
+ Misses      20727    20705      -22     
  Partials       53       53              
Flag Coverage Δ
unit 46.37% <94.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles force-pushed the 1999-styleguide-e2e-isolation branch from 6d064af to 335559a Compare May 10, 2024 14:57
@bmingles bmingles linked an issue May 21, 2024 that may be closed by this pull request
@bmingles bmingles changed the title refactor: e2e isolation refactor: SampleSection component to conditionally render based on route May 22, 2024
@bmingles bmingles marked this pull request as ready for review May 22, 2024 21:02
@bmingles bmingles requested a review from mofojed May 22, 2024 21:09
@bmingles bmingles merged commit 236a10e into deephaven:main May 23, 2024
15 checks passed
@bmingles bmingles deleted the 1999-styleguide-e2e-isolation branch May 23, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styleguide e2e tests - share page state
2 participants