Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps-dev: Update to TypeScript 5 #165

Merged
merged 1 commit into from Mar 21, 2023
Merged

deps-dev: Update to TypeScript 5 #165

merged 1 commit into from Mar 21, 2023

Conversation

jpveooys
Copy link
Contributor

This updates to TypeScript 5. It includes removing some workarounds for a bug in TypeScript 4.9 relating to dynamic imports.

We may want to look at using the new bundler option for moduleResolution at some point but haven't done anything related to that here.

@jpveooys jpveooys marked this pull request as ready for review March 17, 2023 15:43
Copy link
Contributor

@adamledwards adamledwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice is the change from for...of to Promise.all part of the ts5 update or just a general refactor

@jpveooys
Copy link
Contributor Author

@adamledwards

It includes removing some workarounds for a bug in TypeScript 4.9 relating to dynamic imports.

microsoft/TypeScript#51554 was the bug that seemed to be causing the previous problems.

This updates to TypeScript 5. It includes removing some workarounds for a bug in TypeScript 4.9 relating to dynamic imports.

We may want to look at using the [new `bundler` option for `moduleResolution`](https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#moduleresolution-bundler) at some point but haven't done anything related to that here.
@jpveooys jpveooys enabled auto-merge March 21, 2023 17:15
@jpveooys jpveooys merged commit e84fd80 into main Mar 21, 2023
12 checks passed
@jpveooys jpveooys deleted the deps-dev/typescript-5 branch March 21, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants