test: data injection flake #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
|
Still seeing the flake. More investigation and experimentation needed https://github.com/defenseunicorns/zarf/actions/runs/8175786653/job/22353838067?pr=2361#step:8:5656 |
…g pod Using the --selector=app=kiwix-serve flag to fetch logs sometimes results in the query trying to fetch logs from a pod that is terminating, but still matches the selector. This commit also changes k8s.GetPods() to allow callers to use more customizable query options.
lucasrod16
requested review from
jeff-mccoy,
Racer159,
Noxsios and
AustinAbro321
as code owners
Racer159
reviewed
Mar 6, 2024
AustinAbro321
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes data injection test flake
Related Issue
Fixes #2360
Type of change
Checklist before merging