fix: hotfix skeleton publish #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: razzle <harry@razzle.cloud>
Noxsios
requested review from
jeff-mccoy,
Racer159,
lucasrod16 and
AustinAbro321
as code owners
✅ Deploy Preview for zarf-docs canceled.
|
AustinAbro321
previously approved these changes
Mar 22, 2024
lucasrod16
previously approved these changes
Mar 22, 2024
Signed-off-by: razzle <harry@razzle.cloud>
lucasrod16
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hotfixes skeleton publish. However, this breakage has revealed that the entire
skeletoncreation + publishing flow is flawed and requires an overhaul. Currently, whileskeletonsays it has anarchofskeleton, it is actually honoring the--architectureflag and resulting in askeletonpackage that is single architecture. It is also not honoringflavor.Type of change