Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade colors.js to 1.4.0 #35

Merged
merged 3 commits into from Jan 21, 2022
Merged

Downgrade colors.js to 1.4.0 #35

merged 3 commits into from Jan 21, 2022

Conversation

gas1cent
Copy link
Member

See this for context Marak/colors.js#285

@gas1cent gas1cent self-assigned this Jan 18, 2022
@404skillz
Copy link
Contributor

Is there a way we can set this in resolutions within the package.json ? I fear someone might delete the yarn.lock and this change is missed :)

@drgorillamd
Copy link
Member

Is there a way we can set this in resolutions within the package.json ? I fear someone might delete the yarn.lock and this change is missed :)

Just added it, npm list colors :
image

@404skillz 404skillz self-requested a review January 21, 2022 20:01
404skillz
404skillz approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@404skillz 404skillz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work guys ! Thank you !

@404skillz 404skillz merged commit 8acbb94 into main Jan 21, 2022
@404skillz 404skillz deleted the fix/downgrade-colors branch January 21, 2022 20:02
@404skillz 404skillz mentioned this pull request Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@404skillz 404skillz 404skillz approved these changes

Assignees

@gas1cent gas1cent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gas1cent @404skillz @drgorillamd