Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to python 3.12 #3

Closed
wants to merge 6 commits into from
Closed

Upgrade to python 3.12 #3

wants to merge 6 commits into from

Conversation

rapidmod
Copy link

@rapidmod rapidmod commented Apr 9, 2024

  1. upgraded to python 3.12
  2. added chardet to test for proper encodings
  3. added variables to use persistent db (and not create it each time)
  4. added variables to ignore errors to continue the script instead of failing
  5. upgraded langchain models and src imports

@rapidmod
Basic almost working
55e0839
@rapidmod
working and will build, see "Dev Notes" in README.md
8a1ac41
@rapidmod
put back in appropriate directory, builds fails loading langchain schema
6485300
@rapidmod
update git ignore and remove test.py from the repo
8dd56fe
@rapidmod
- Works in python 3.12
12e97bd 
- upgrade lambda libraries
- added refresh and db path for persistent db
- basic persistent test.py and .ipynb
@rapidmod
- added chardet to check and or convert encodings for less errors
bcd2778 
- added ignore errors param to skip errors instead of failing on them
-- run for 6hrs and processed 59k files without errors
@rapidmod
Copy link
Author

rapidmod commented Apr 11, 2024 •
edited

There is 1 more problem
Your package is my first python project with MAKEFILE I don't feel comfortable upgrading the requirements in your project. I have the basic concept but I don't fully understand everything that's goes on when you use MAKEFILE or flit. I do have the requirements.txt file.

Either way I did learn from your project and will be implementing some of what I learned in my own projects. I did the work to update it so you didn't have too as thank you, use it as you wish or if you want me to add or change something let me know

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 12, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricklamers ricklamers ricklamers left review comments

Assignees
No one assigned
Labels
Stale
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rapidmod @ricklamers