Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation WSOD #454

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Fix documentation WSOD #454

merged 2 commits into from
Jan 6, 2024

Conversation

jorisdrenth
Copy link
Contributor

@jorisdrenth jorisdrenth commented Jan 5, 2024

As discussed in #453, this commit fixes a couple of things:

  • White screen in documentation main page, 404 on all other pages
  • Some documentation markdown files were deleted
  • There was a FATAL error in Nuxt related to @nuxtjs/tailwindcss, that's why I pinned an slightly older version in package.json

Overall this fixes it, but I think the docs need a technical update since there still are a lot of errors / warnings when running the NPM commands to start Nuxt.

And fixed a wrong command in the docs readme
@jorisdrenth
Copy link
Contributor Author

@fabio-ivona Do you have time to check this PR, so documentation will be available again? Thanks!

@fabio-ivona fabio-ivona merged commit e51733e into defstudio:main Jan 6, 2024
@fabio-ivona
Copy link
Member

Just deploying in production, thanks @jorisdrenth

@fabio-ivona
Copy link
Member

@jorisdrenth docs are back online, but image assets seems missing to me, could you please check it? I'm from phone right now and it is quite difficult for me

@jorisdrenth
Copy link
Contributor Author

@fabio-ivona Sure, I'll take a look later today!

@fabio-ivona
Copy link
Member

Update, just some images missing: eg. https://defstudio.github.io/quickstart/new-bot

@jorisdrenth
Copy link
Contributor Author

@fabio-ivona See #455

@fabio-ivona
Copy link
Member

Thanks @jorisdrenth you made my day! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants