Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add contribution ladder #560

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sajayantony
Copy link
Contributor

Signed-off-by: Sajay Antony sajaya@microsoft.com

Description

What this PR does / why we need it:

This add the contribution ladder template for the Ratify project and is based of https://github.com/cncf/project-template/blob/main/CONTRIBUTING.md

The current template outlines only a subset of roles.

/cc @bridgetkromhout @akashsinghal @toddysm @susanshi @binbin-li

Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Copy link
Collaborator

@toddysm toddysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments:

  • We should remove the wording that this is a template and adopt for this specific project
  • We should define the two missing roles

@@ -0,0 +1,111 @@
# Contributor Ladder Template
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the wording that this is a template and adjust it to the needs of the project.


* Responsibilities include:
* Follow the code of conduct
* Follow the project contributing guide
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to the guide would be good

* [Contributor Ladder](#contributor-ladder-template)
* [Community Participant](#community-participant)
* [Contributor](#contributor)
* [Organization Member](#organization-member)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see descriptions of Org Member and Reviewer below. Are those defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Ratify is not an ORG maybe when we move it and we can add it at that point in time since this would also need to be reviewed.

* Privileges:
* Invitations to contributor events

### Maintainer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be noted that a maintainer can be on a project level (includes all sub-projects) or sub-project level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently Ratify doesn't have a sub project so do you want me to include the clause?

* Determining strategy and policy for the project
* Participating in, and leading, community meetings
* Requirements
* Experience as a Reviewer for at least 4 months
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again Reviewer is not defined in this document.

* Have a vote in Maintainer decision-making meetings


Process of becoming a maintainer:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there exceptions to this process?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering not and if there are we should update this doc for transparency.

@akashsinghal akashsinghal changed the title Add contribution ladder chore: Add contribution ladder Mar 6, 2023
@sajayantony
Copy link
Contributor Author

This PR might sit in draft form for a while since folks are ironing out definitions in related projects.

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (839a83b) 51.72% compared to head (68bc554) 51.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files          61       61           
  Lines        3555     3555           
=======================================
  Hits         1839     1839           
  Misses       1529     1529           
  Partials      187      187           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants