[Spark] Identity Columns Value Generation (without MERGE support) #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c27kwan
changed the title
c27kwan
commented
May 2, 2024
Comment on lines
+74
to
+75
| // Ingest using MERGE INTO ... WHEN NOT MATCHED INSERT | ||
| val mergeInsert = Value |
There was a problem hiding this comment.
This is part about merge is not used yet, it's just easier to commit the test infrastructure in this PR.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR is part of #1959
In this PR, we enable basic ingestion for Identity Columns.
GenerateIdentityValuesto generate values when not supplemented by the user.Note: This does NOT enable Ingestion with MERGE INTO yet. That will come in a follow up PR, to make this easier to review.
How was this patch tested?
We introduce a new test suite IdentityColumnIngestionSuite.
Does this PR introduce any user-facing changes?
No.