Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGB Support #50

Open
froggestspirit opened this issue Jan 30, 2022 · 5 comments
Open

CGB Support #50

froggestspirit opened this issue Jan 30, 2022 · 5 comments
Labels
diff: complex A difficult issue; may require significant planning. enhancement New feature or request feat: crucial For significant tasks; expected to be fixed before next release.
Milestone

Comments

@froggestspirit
Copy link
Contributor

froggestspirit commented Jan 30, 2022

I added CGB support here:
https://github.com/froggestspirit/Peanut-GB

I only really tested this with Pokemon Crystal, but seemed to work fine. I wasn't sure if you might want to merge it, or copy parts of it over, I know there's some formatting differences, and also the way I handled sram.

I should also note, this might only be working in the SDL2 example for now, since some changes to the C file were necessary there for rendering the palettes.

@deltabeard
Copy link
Owner

deltabeard commented Feb 2, 2022

Thank you for your work! 😃

I would be happy if you could make a pull request, and then I can start reviewing the code. At a glance:

  • the formatting of code you haven't modified shouldn't be altered. So maybe we could cherry-pick 04cef56 ?
  • the CGB code should be within ifdefs to allow developers to disable it if their target environment has very little RAM and processing power.
  • uint8_t should only be used for 8-bit integers and not for bit fields that aren't 8-bits. Using uint8_t for bitfields was correct.
  • group the CGB if statements on lines 3646 to 3652 together.
  • why is num_rom_banks_mask reverted to the previous version? Those three ROM size masks aren't ever used apparently.

@victorbnl
Copy link

The repository has been archived, I guess the author has no intention to make these changes nor to make it a pull request anymore

@deltabeard deltabeard added this to the v2 milestone May 30, 2022
@deltabeard deltabeard added enhancement New feature or request diff: complex A difficult issue; may require significant planning. feat: low-impact A low impact feature; not important but desired. labels May 30, 2022
@deltabeard
Copy link
Owner

I plan on adding this feature in v2 as this will require an API change. I'll plan and put more thought into this at a later date.

@deltabeard deltabeard modified the milestones: v2, v3 Aug 4, 2022
Lisra-git added a commit to Lisra-git/peanutgb that referenced this issue Dec 9, 2022
@deltabeard deltabeard added feat: crucial For significant tasks; expected to be fixed before next release. and removed feat: low-impact A low impact feature; not important but desired. labels Feb 23, 2023
@tvecera tvecera mentioned this issue Jul 17, 2023
@kevinjones120
Copy link

kevinjones120 commented May 9, 2024

can I use a st7789vw 2 inch display or can you make support for it please.

@deltabeard
Copy link
Owner

can I use a st7789vw 2 inch display or can you make support for it please.

That's not relevant to this issue. You can probably use that display but you have to add support for it yourself. This repository is just for the emulation core. The display driver has to be written by yourself.

Repository owner deleted a comment from kevinjones120 May 14, 2024
Repository owner locked as off-topic and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
diff: complex A difficult issue; may require significant planning. enhancement New feature or request feat: crucial For significant tasks; expected to be fixed before next release.
Projects
None yet
Development

No branches or pull requests

4 participants