-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync chats deletion across devices #5007
base: main
Are you sure you want to change the base?
Conversation
.await | ||
.log_err(context) | ||
.ok(); | ||
} | ||
|
||
if chat.is_self_talk() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this even before the actual deletion so that this message can't be missing if we fail halfway. But then the stock string should be changed to You are deleting the \"Saved messages\" chat...
or smth like this
general comment: please describe a description for your PRs, summarizing the motivation/reason and the approach/solution. |
af8c179
to
32ba7f2
Compare
Added a commit message. Yes, i hurried to share this work. Actually it should be a draft w/o good commit messages |
I have mixed feelings about chat deletion, users might expect it to delete all imap emails / messages from that chat too. I wouldn't sync chat deletion before we sync message deletion. |
But these are independent things actually, one doesn't make another worse. |
For deletion current plan is not to release it into 1.42 series and stabilize everything else first. Deletion is destructive and therefore dangerous, let's test how well pinning/renaming works first on a large scale. |
There may be a problem with synchronising chats deletion -- if another device has |
32ba7f2
to
520d6ce
Compare
Motivation: Now broadcast lists creation is synced across devices. Groups creation, in some means, too -- on a group promotion by a first message. So, to make this looking more feature-complete, sync chats deletion too. An approach is to replay a user action on synchronised devices because the chat deletion is a complex procedure affecting several tables, self-chat, emitting the corresponding event etc. Also this commit makes all deletions to happen in a transaction, to be on a safe side.
520d6ce
to
171739f
Compare
1abb12e
to
2af9ff1
Compare
feat: Sync chats deletion across devices
Motivation: Now broadcast lists creation is synced across devices. Groups creation, in some means, too -- on a group promotion by a first message. So, to make this looking more feature-complete, sync chats deletion too.
An approach is to replay a user action on synchronised devices because the chat deletion is a complex procedure affecting several tables, self-chat, emitting the corresponding event etc.
Also this commit makes all deletions to happen in a transaction, to be on a safe side.