api(deltachat-jsonrpc): return vCard contact directly in MessageObject #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/jsonrpc-vcard-contact
branch
from
1e59513
to
ba56703
Compare
iequidoo
approved these changes
May 17, 2024
| { | ||
| parse_vcard(vcard).into_iter().map(Into::into).collect() | ||
| } else { | ||
| Vec::new() |
There was a problem hiding this comment.
Maybe just make vcard_contacts mutable? This 3-story vector initialisation looks too verbose
There was a problem hiding this comment.
I moved this into a separate function to use ? instead.
link2xt
force-pushed
the
link2xt/jsonrpc-vcard-contact
branch
from
ba56703
to
70c759d
Compare
link2xt
changed the title
iequidoo
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.