Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS bug for TLS over TLS proxy #65

Merged
merged 19 commits into from May 2, 2022
Merged

Fix TLS bug for TLS over TLS proxy #65

merged 19 commits into from May 2, 2022

Commits on Feb 19, 2022

  1. Fix TLS bug preventing HTTPS-over-HTTP(S) proxying 

    Without this fix, you see this error when attempting to use an HTTPS proxy.

`Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: foo.com. is not in the cert's altnames: DNS:*.bar.com, DNS:bar.com`

The `servername` attribute is able to fix this behavior when passed to the underlying `tls.connect()` call inside of the `https` module. (see the Node [docs](https://nodejs.org/api/https.html#httpsrequesturl-options-callback))

This was very painful to debug but now I understand how `CONNECT` works extremely well! Cheers.

FIxes delvedor#43
    @freeqaz
    freeqaz committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    d28f6d2 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Run lint (standard)

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c68715d View commit details
    Browse the repository at this point in the history

  2. Gen certs, keys, fix https-over-http

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    b9d8ae1 View commit details
    Browse the repository at this point in the history

  3. Fix https over https

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    f67e915 View commit details
    Browse the repository at this point in the history

  4. Fix http over https

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    1ab5f06 View commit details
    Browse the repository at this point in the history

  5. Fix got

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    e7686db View commit details
    Browse the repository at this point in the history

  6. needle fix

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    42b104c View commit details
    Browse the repository at this point in the history

  7. Fix node fetch

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    5086d2e View commit details
    Browse the repository at this point in the history

  8. Fix simple get

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    d1d2511 View commit details
    Browse the repository at this point in the history

  9. Run lint / standard

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    974606a View commit details
    Browse the repository at this point in the history

  10. Update test command to provide extra certs

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    e96f40b View commit details
    Browse the repository at this point in the history

  11. version bump

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    f3e2d36 View commit details
    Browse the repository at this point in the history

  12. Fix implementation for Node v10

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    669163a View commit details
    Browse the repository at this point in the history

  13. Try env var for windows

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    c3d5181 View commit details
    Browse the repository at this point in the history

  14. env directive

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    909810b View commit details
    Browse the repository at this point in the history

  15. Merge pull request #1 from ckcr4lyf/patch-test 

    Add unit tests, backport Free's fix for Node v10, setup workflow for windows env var
    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    457ba69 View commit details
    Browse the repository at this point in the history

  16. remove irelevant comment

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    e8b7666 View commit details
    Browse the repository at this point in the history

  17. undo version bump

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    4f50ca7 View commit details
    Browse the repository at this point in the history

  18. Move SSL certs, keys to fixtures, ignored in npmignore

    @ckcr4lyf
    ckcr4lyf committed May 2, 2022
    Configuration menu
    Copy the full SHA
    2c5263a View commit details
    Browse the repository at this point in the history