Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private from content docs #1551

Merged
merged 5 commits into from
May 19, 2024
Merged

Conversation

omerKarkKatz
Copy link
Contributor

@omerKarkKatz omerKarkKatz commented May 9, 2024

Status

Ready/In Progress/In Hold (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Screenshots

Paste here any images that will help the reviewer

Copy link

welcome bot commented May 9, 2024

Welcome! Thank you and congrats on your first pull request.

What happens next?

  • CircleCI is building a preview of the site with your modifications.
  • Once the build is complete a preview will be available and a comment with a link will be posted.
  • A member of the team will then review the pull request and provide feedback as needed.
  • If all is good and the pull request has passed review, you will be able to merge the PR.

Good luck to us all!

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1551-mrv4pcva.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

Copy link
Contributor

@MosheEichler MosheEichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Please see my comment

content-repo/gendocs.py Show resolved Hide resolved
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1551-r29vv2hm.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@omerKarkKatz omerKarkKatz merged commit 9e3f60b into master May 19, 2024
8 checks passed
@omerKarkKatz omerKarkKatz deleted the remove_private_from_content_docs branch May 19, 2024 08:15
Copy link

welcome bot commented May 19, 2024

Congrats on merging your first pull request!

We are now creating a production deploy. In about 30 minutes our site: https://xsoar.pan.dev will be updated with the changes from this PR.

@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed successfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants