Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix handler, add samesite cookie parameter #19

Merged
merged 1 commit into from Jan 26, 2020
Merged

fix handler, add samesite cookie parameter #19

merged 1 commit into from Jan 26, 2020

Conversation

TomFern
Copy link
Contributor

@TomFern TomFern commented Jan 25, 2020

I'm updating the tutorial post on Semaphore blog.

I found that this project no longer builds, as Gin Context setCookie now requires an additional parameter:

gin-gonic/gin#1615

I added the missing parameter with its default value and it seems it's working.

@kulshekhar
Copy link
Contributor

@TomFern Thanks for updating the code!

@kulshekhar kulshekhar merged commit a4cfa04 into demo-apps:master Jan 26, 2020
@TomFern TomFern deleted the fix-cookies branch January 28, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants