Add back TypeScript version for -v flag using package.json info

[kevinkassimo]

Similar to the way we pass deno crate version

[ry]

Hrm. This works, but it's kinda ad hoc... We have a similar situation with deno.platform where we need to inject some information into the build. It's done using rollup here:

deno/rollup.config.js

Lines 92 to 124 in 748b0f9

	/** Inject deno.platform.arch and deno.platform.os
	* @param {any} param0
	*/
	function platform({ include, exclude } = {}) {
	if (!include) {
	throw new Error("include option must be passed");
	}
	const filter = createFilter(include, exclude);
	return {
	name: "platform",
	/**
	* @param {any} _code
	* @param {string} id
	*/
	transform(_code, id) {
	if (filter(id)) {
	// Adapted from https://github.com/rollup/rollup-plugin-inject/blob/master/src/index.js
	const arch = archNodeToDeno[process.arch];
	const os = osNodeToDeno[process.platform];
	// We do not have to worry about the interface here, because this is just to generate
	// the actual runtime code, not any type information integrated into Deno
	const magicString = new MagicString(`
	export const platform = { arch: "${arch}", os:"${os}" };`);
	return {
	code: magicString.toString(),
	map: magicString.generateMap()
	};
	}
	}
	};
	}

What do you think about doing something similar for the TS version?

[kitsonk]

Yeah, I think that makes much more sense, though it sort of would be great not to have to go to JavaScript at all, the other two strings exist in Rust already and we pass it to JS to just print it out.

[kevinkassimo]

Yeah it should also work (this platform injection was also done by me quite a while ago). Probably we can centralize all the injected variables during build in a single file (to avoid being too messy in the future when we possibly also inject other stuff)? I'll go and work on that if sound okay.

Another problem I realized with GN injection is that it would not work with cargo build, unless specially handled in build.rs...

[ry]

though it sort of would be great not to have to go to JavaScript at all

I don't think that's worth optimizing for.

Another problem I realized with GN injection is that it would not work with cargo build, unless specially handled in build.rs...

Good point

It would be good to have access to the versions in the runtime environment - maybe that can be done as part of this work... deno.version.v8 for example would be nice to have.

[kt3k]

How about using rollup-plugin-replace for embedding the version number in script? The plugin can replace certain types of symbols in scripts with the supplied values.

[kt3k]

I did a simple experiment using rollup-plugin-replace on my fork. It seems working and this looks a little simpler than this patch (the diff is +11,-2).

@kevinkassimo @ry
If you're ok, I'd like to continue work on this issue on my branch.

[kevinkassimo]

@kt3k SGTM. I'll close this once you have your PR set up.

[kevinkassimo]

Closed in favor of #1788