-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back typescript version number and add Deno.version object. #1788
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c9d742f
feat: print typescript version
kt3k 93a0f8b
feat: add Deno.version
kt3k a389d5f
refactor: add setVersions function
kt3k 849b184
refactor: use TS_VERSION in string literal
kt3k c72ef14
refactor: simplify the types
kt3k aa5a284
test(js/version): better assertions
kt3k 844ed4c
feat: prevent the leak of internal function
kt3k File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. | ||
interface Version { | ||
deno: string; | ||
v8: string; | ||
typescript: string; | ||
} | ||
|
||
export const version: Version = { | ||
deno: "", | ||
v8: "", | ||
typescript: "TS_VERSION" // This string will be replaced by rollup | ||
}; | ||
|
||
/** | ||
* Sets the deno and v8 versions and freezes the version object. | ||
* @internal | ||
*/ | ||
export function setVersions(denoVersion: string, v8Version: string): void { | ||
version.deno = denoVersion; | ||
version.v8 = v8Version; | ||
|
||
Object.freeze(version); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { test, assert } from "./test_util.ts"; | ||
|
||
test(function version() { | ||
const pattern = /^\d+\.\d+\.\d+$/; | ||
assert(pattern.test(Deno.version.deno)); | ||
assert(pattern.test(Deno.version.v8)); | ||
assert(pattern.test(Deno.version.typescript)); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule third_party
updated
26 files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would set this to
@internal
so it doesn't get leaked to the runtime type library.