Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node:fs/promises): add missing cp and cpSync #22031

Closed
wants to merge 3 commits into from

Conversation

jaw0r3k
Copy link

@jaw0r3k jaw0r3k commented Jan 22, 2024

I dont think the pull request requires any tests
Fixes a bug mentioned in discordjs/discord.js#9810

As author of df062d2 added support for that didnt add it directly to fs/promises

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jaw0r3k jaw0r3k changed the title fix: add cp to node:fs/promises fix(node:fs/promises): add missing cp and cpSync Jan 22, 2024
@bartlomieju
Copy link
Member

Thanks for the PR @jaw0r3k! I think it would be useful to have a test that checks for presence of these API - could you add some simple assertions that verify that promises.cp and promises.cpSync actually exist?

@bartlomieju bartlomieju added this to the 1.40 milestone Jan 23, 2024
@bartlomieju bartlomieju removed this from the 1.40 milestone Jan 23, 2024
@jaw0r3k
Copy link
Author

jaw0r3k commented Feb 14, 2024

Superseded by #22263

@jaw0r3k jaw0r3k closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants