Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-api): implement napi_type_tag_object #22705

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(node-api): implement napi_type_tag_object #22705

wants to merge 2 commits into from
+75 −1

Conversation

littledivy
Copy link
Member

Fixes #22692

aapoalas
aapoalas requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The object_wrap tests seem to have started failing.

@littledivy
Copy link
Member Author

Interesting, it's only failing on Windows. Time to whip out the windows machine ig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aapoalas aapoalas aapoalas requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement napi_type_tag_object
2 participants
@littledivy @aapoalas