fix(ext/node): homedir() getpwuid/SHGetKnownFolderPath fallback

[littledivy]

Unix: Returns the value of the HOME environment variable if it is set even if it is an empty string. Otherwise, it tries to determine the home directory by invoking the getpwuid_r function with the UID of the current user.

Windows: Returns the value of the USERPROFILE environment variable if it is set and it is not an empty string. Otherwise, it tries to determine the home directory by invoking the SHGetKnownFolderPath function with FOLDERID_Profile.

Fixes #23824

[satyarohith]

LGTM

I wonder if we need to expose a similar API in deno (not for now though).

[prabhu]

We are seeing some build failures such as this with the latest deno.

error: Uncaught (in promise) PermissionDenied: Requires sys access to "homedir", run again with the --allow-sys flag
    at Object.homedir (node:os:46:10)
    at Object.<anonymous> (file:///home/runner/work/cdxgen/cdxgen/node_modules/.deno/clean-stack@2.2.0/node_modules/clean-stack/index.js:6:61)
    at Object.<anonymous> (file:///home/runner/work/cdxgen/cdxgen/node_modules/.deno/clean-stack@2.2.0/node_modules/clean-stack/index.js:42:4)
    at Module._compile (node:module:659:34)
    at Object.Module._extensions..js (node:module:673:10)
    at Module.load (node:module:597:32)
    at Function.Module._load (node:module:484:12)
    at Module.require (node:module:609:19)
    at require (node:module:715:16)

Is it related to this PR?

[littledivy]

@prabhu yes, it requires the --allow-sys=homedir permission flag because of the use of OS-level APIs.

deno run --allow-sys=homedir or deno run --allow-sys

[prabhu]

@littledivy, thank you for clarifying. Reading the source code for cargo home, it appears like this permission is required only for Windows. Can you correct me, if I am wrong? If sys permission isn't available, can it fallback to using the old env variable approach?

[littledivy]

It is also required on unix: See https://docs.rs/home/0.5.9/src/home/lib.rs.html#68-72 which calls https://doc.rust-lang.org/std/env/fn.home_dir.html.

This is marked as a fix because without a generic permission --allow-sys any internal changes to the implementation would break permission requirements.