Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get the correct option #114

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: get the correct option #114

wants to merge 2 commits into from

Conversation

hong4rc
Copy link
Contributor

@hong4rc hong4rc commented Dec 7, 2020

Relate #92

  • Remove exactly option in args instead of args[0] (use Array.protpty.splice to remove)
  • Chang option --config, '-c' to --cfg (conflict option with deno)
  • Fixed wrong version for --upgrade: --upgrade latest become latest instead of vlates

Old parseArgs(["--cfg", "config.json"]):
image

Old parseArgs(["--upgrade", "latest"]):
image

Test #92: deno install -n denon2 -qAf --unstable https://raw.githubusercontent.com/hong4rc/denon/option/denon.ts

and call denon2 run -A --config tsconfig.json main.ts

and got:

[!] [#0] starting --config tsconfig.json main.ts

@hong4rc hong4rc changed the title fix: get right option fix: get the correct option Dec 7, 2020
@hong4rc
Copy link
Contributor Author

hong4rc commented Dec 18, 2020

@eliassjogreen Are you want to use this or force --config is the first argument?

@eliassjogreen eliassjogreen requested review from notfilippo and eliassjogreen and removed request for notfilippo January 6, 2021 15:33
@eliassjogreen
Copy link
Member

Sorry for taking so long, whats your thought on this @Qu4k?

@aadamsx
Copy link

aadamsx commented Feb 26, 2021

Is this repo not being maintained? If not are there forks with activity and response/feedback from the developers?

@nnmrts
Copy link
Contributor

nnmrts commented Nov 23, 2021

I don't know if this PR is still relevant but I would advise against merging in this state. .splice() mutates an array, but Deno.args is immutable and Deno errors if you try to mutate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants