Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1500 file input v3 e2e #1031

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

1500 file input v3 e2e #1031

wants to merge 22 commits into from

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Jan 19, 2024 •
edited by github-actions bot

Chromatic

https://1500-file-input-v3-e2e--60f9b557105290003b387cd5.chromatic.com

Description

Closes

QA Checklist

  • Component maintains 1:1 parity with design mocks
  • Text is consistent with what's been provided in the mocks
  • Component behaves as expected across breakpoints
  • Accessibility expert has signed off on code changes (if applicable. If not applicable provide reason why)
  • Designer has signed off on changes (if applicable. If not applicable provide reason why)
  • Tab order and focus state work as expected
  • Changes have been tested against screen readers (if applicable. If not applicable provide reason why)
  • New components are covered by e2e tests; updates to existing components are covered by existing test suite
  • Changes have been tested in vets-website using Verdaccio (if applicable. If not applicable provide reason why)

Screenshots

Acceptance criteria

  • QA checklist has been completed
  • Screenshots have been attached that cover desktop and mobile screens

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

@Andrew565
WIP switching branches
0586c45
@Andrew565
USWDS V3-compatible File Input
5f19d2c
@Andrew565
Merge remote-tracking branch 'origin/main' into 1500-file-input-v3
737f017
@Andrew565
Adding missing asterisk
11c62c3
@Andrew565
Version bump
81a2d38
@Andrew565
Adding tests
a15f1f6
@Andrew565
Removing onChange call
3fda17f
@Andrew565
Attempt at improving change event handling
3911d25
@Andrew565
Changing file input storybook to use React binding
73564c0
@Andrew565
Style updates
7bfbc76
@Andrew565
Merge branch 'main' into 1500-file-input-v3
609ae83
@Andrew565
Fixes to event handling and testing (from Jami)
51c8860
@Andrew565
Fixes for drag-and-drop and change events
4f1ee29
@Andrew565
Merge branch 'main' into 1500-file-input-v3
537a562
@Andrew565
Update package.json
e849f23
@Andrew565
Removing changelistnerid
3750b4a 
No longer needed
@Andrew565
Style fixes
1c8e9a5
@Andrew565
Fix to 'generic' preview image sizes when uploading
e27a268
@Andrew565
Removing no-longer-needed styles
4736244
@Andrew565
Fixing version bump
877acbc
@Andrew565
Change sr-only to usa-sr-only
3bc4d00
@Andrew565
Removing uswds reflectivity
c0ad798
@jamigibbs jamigibbs added the ignore-for-release Used if you want to ignore the PR in the generated release notes label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ignore-for-release Used if you want to ignore the PR in the generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamigibbs @Andrew565