va-button: adding independent chevron icon prop [WIP] #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://va-button-icon-prop--60f9b557105290003b387cd5.chromatic.com
Configuring this pull request
major
,minor
,patch
, orignore-for-release
).ignore-for-release
if files haven't been changed in a component library package. (ie. only Storybook files)/packages/core
version number if this will be the last PR merged before a release.Description
Test PR to see if this is a viable change that could benefit with button customization in the forms system by adding
chevronLeft
andchevronRight
props tova-button
which work with the existing back/continue prop functionality for displaying the left/right chevron icons in the button text. I'm not super hip with component library changes, so if there needs to be adjustments feel free to let me know!Some background:
We use a number of custom pages and based on accessibility feedback it's beneficial to have custom text in the progression buttons that convey what page is coming up next. This has resulted in some extensive customization to get buttons like the following implemented and this change could help in a major way! This is mostly as a response to the feedback we received on some heavy styling changes we're looking to implement.
QA Checklist
Screenshots
Acceptance criteria
Definition of done