VACMS-3904 Remove deploy steps from tests.yml & change order of deploy steps to match drush deploy
#4378
Conversation
This was only for DevShop to run things, DevShop is gone now and we don't need these anymore.
…atch `drush deploy`.
| # Follows `drush deploy` sequence recommendations - https://www.drush.org/latest/deploycommand/ | ||
| # Replace with `drush deploy` once Drush 10 is upgraded | ||
| # If updated, also update in devops:post-deploy-tasks.yml and .tugboat/config.yml | ||
| - appserver: cd $LANDO_WEBROOT && drush updatedb --cache-clear=0 -y |
There was a problem hiding this comment.
Does this pattern BRD?
There was a problem hiding this comment.
Now it does, I updated BRD to match in https://github.com/department-of-veterans-affairs/devops/pull/8557/files.
There was a problem hiding this comment.
What's the reason for changing from doing a cache clear as the first step, to removing it AND setting the --cache-clear=0 option?
It is because Drush 10 recommends that sequence, See https://www.drush.org/latest/deploycommand/.
Also, Drush 10 will have the drush updatedb --no-cache-clear option, and until then it will be --cache-clear=0.
There was a problem hiding this comment.
@ElijahLynn what scenarios did you test?
I just tested that tests pass in local Lando, Tugboat and BRD.
| @@ -111,11 +112,14 @@ services: | |||
| - j2 "${TUGBOAT_ROOT}/.tugboat/.env.j2" -o "${TUGBOAT_ROOT}/.env" | |||
| # This command is shared by the clone and build stages, make sure to update both stages. | |||
| - j2 "${TUGBOAT_ROOT}/.web/403-error-document.j2.html" -o "${TUGBOAT_ROOT}/.web/403-error-document.html" | |||
| - composer install --optimize-autoloader --apcu-autoloader | |||
There was a problem hiding this comment.
Removed this since we declare the same ones in composer.json config key and easier to maintain across Lando, Tugboat and BRD.
There was a problem hiding this comment.
Yeah, I saw -- IDK why I didn't replace that in my original PR 🤷♂️
There was a problem hiding this comment.
thanks for confirming!
ElijahLynn
changed the title
drush deploy
|
@ElijahLynn what scenarios did you test? |
| # Follows `drush deploy` sequence recommendations - https://www.drush.org/latest/deploycommand/ | ||
| # Replace with `drush deploy` once Drush 10 is upgraded | ||
| # If updated, also update in devops:post-deploy-tasks.yml and .tugboat/config.yml | ||
| - appserver: cd $LANDO_WEBROOT && drush updatedb --cache-clear=0 -y |
There was a problem hiding this comment.
What's the reason for changing from doing a cache clear as the first step, to removing it AND setting the --cache-clear=0 option?
There was a specific reason we add the initial cache clear but I don't recall what it was.
There was a problem hiding this comment.
The initial cache rebuild was because I copied it from https://drupal.stackexchange.com/a/254411/6602. The answer is now updated with these new recommendations, it appears.
| - drush cache:rebuild | ||
| - drush config:import -y | ||
| - drush updatedb --cache-clear=0 -y |
There was a problem hiding this comment.
This old order seems wrong, so YES I approve making it consistent with our other steps.
Description
The deploy steps in tests.yml was only for DevShop to run things because we were using it outside its expected behavior. DevShop is gone now and we don't need these anymore.
The deploy steps order is changed to match the
drush deployrecommendations. See https://www.drush.org/latest/deploycommand/The composer install autoloader options are removed from Tugboat as we have them in composer.json config section.
#3904
Deploy steps changes are also in BRD here > https://github.com/department-of-veterans-affairs/devops/pull/8557
Testing done