Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] Manually set the maximum # of retries for EVSS::RequestDecision job #16744

Merged
merged 6 commits into from
May 30, 2024

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented May 14, 2024

Summary

Manually setting the maximum # of retries for the EVSS::RequestDecision Sidekiq job. Setting it to 14 so that it will exhaust its retries in ~48 hours instead of ~3 weeks. This is a more reasonable timeframe and allows us to debug failures more easily (APM traces are only retained for 2 weeks)

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this May 14, 2024
@va-vsp-bot
Copy link
Collaborator

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/evss/request_decision.rb

@va-vfs-bot va-vfs-bot temporarily deployed to 82667-set-requestdecision-max-retries/main/main May 14, 2024 18:35 Inactive
@jerekshoe jerekshoe marked this pull request as ready for review May 14, 2024 20:08
@jerekshoe jerekshoe requested a review from a team as a code owner May 14, 2024 20:08
@va-vfs-bot va-vfs-bot temporarily deployed to 82667-set-requestdecision-max-retries/main/main May 14, 2024 22:19 Inactive
rjohnson2011
rjohnson2011 previously approved these changes May 17, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 82667-set-requestdecision-max-retries/main/main May 22, 2024 16:57 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 82667-set-requestdecision-max-retries/main/main May 22, 2024 19:53 Inactive
@jerekshoe jerekshoe merged commit 6b89a3b into master May 30, 2024
19 checks passed
@jerekshoe jerekshoe deleted the 82667-set-requestdecision-max-retries branch May 30, 2024 19:55
stevenjcumming pushed a commit that referenced this pull request May 31, 2024
… job (#16744)

* Manually setting the maximum # of retries for EVSS::RequestDecision job

* Updating CODEOWNERS to account for request_decision.rb file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants