-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CST] Manually set the maximum # of retries for EVSS::RequestDecision job #16744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/evss/request_decision.rb |
va-vfs-bot
temporarily deployed
to
82667-set-requestdecision-max-retries/main/main
May 14, 2024 18:35
Inactive
va-vfs-bot
temporarily deployed
to
82667-set-requestdecision-max-retries/main/main
May 14, 2024 22:19
Inactive
rjohnson2011
previously approved these changes
May 17, 2024
va-vfs-bot
temporarily deployed
to
82667-set-requestdecision-max-retries/main/main
May 22, 2024 16:57
Inactive
va-vfs-bot
temporarily deployed
to
82667-set-requestdecision-max-retries/main/main
May 22, 2024 19:53
Inactive
va-vfs-bot
temporarily deployed
to
82667-set-requestdecision-max-retries/main/main
May 24, 2024 15:34
Inactive
samcoforma
approved these changes
May 28, 2024
rjohnson2011
approved these changes
May 30, 2024
stevenjcumming
pushed a commit
that referenced
this pull request
May 31, 2024
… job (#16744) * Manually setting the maximum # of retries for EVSS::RequestDecision job * Updating CODEOWNERS to account for request_decision.rb file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Manually setting the maximum # of retries for the EVSS::RequestDecision Sidekiq job. Setting it to 14 so that it will exhaust its retries in ~48 hours instead of ~3 weeks. This is a more reasonable timeframe and allows us to debug failures more easily (APM traces are only retained for 2 weeks)
Related issue(s)
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?