Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Pending Tests #16760

Merged
merged 3 commits into from
May 20, 2024
Merged

Skip Pending Tests #16760

merged 3 commits into from
May 20, 2024

Conversation

stevenjcumming
Copy link
Contributor

@stevenjcumming stevenjcumming commented May 15, 2024 •
edited

Summary

The purpose of the PR is to reduce the noise in the CI Run Specs job.

  • By default ignores skipped/pending tests
  • add PENDING environment variable to show skipped/pending tets
  • Allow the CI to skip pending tests
    • Pending tests don't prevent PR approval, so they could be skipped to save time.
  • Update documentation to reflect PENDING environment variable changes

Related issue(s)

Testing done

  • Manual local testing

Acceptance criteria

  • Skipped/pending tests are ignored by default
  • When the PENDING flag is true, pending tests are NOT ignored.
  • Documentation is updated

@stevenjcumming stevenjcumming self-assigned this May 15, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to sjc-skip-pending-ci/main/main May 15, 2024 14:03 Inactive
@stevenjcumming stevenjcumming marked this pull request as ready for review May 15, 2024 14:42
@stevenjcumming stevenjcumming requested review from a team as code owners May 15, 2024 14:42
@stevenjcumming
Copy link
Contributor Author

Planning to merge on 5/20/24

@stevenjcumming stevenjcumming merged commit 6cf1a07 into master May 20, 2024
19 checks passed
@stevenjcumming stevenjcumming deleted the sjc-skip-pending-ci branch May 20, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

Assignees

@stevenjcumming stevenjcumming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stevenjcumming @rjohnson2011 @va-vfs-bot