Add Job that removes old SchemaContract::Validation records

[Tonksthebear]

Summary

Schema contract testing creates records that have limited usefulness beyond the initial few days. This adds a job that removes old records from the database

Related issue(s)

department-of-veterans-affairs/va-mobile-app#8177

Testing done

Add test that ensures the job does the correct thing

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/schema_contract/delete_validation_records_job.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/schema_contract/delete_validation_records_job.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/schema_contract/delete_validation_records_job.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/sidekiq/schema_contract/delete_validation_records_job.rb

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/schema_contract/validation_initiator_spec.rb

[Tonksthebear]

I wasn't sure who to put as the code owners. The whole SchemaContract modules are meant to be available to everyone in vets-api so whichever group would be in charge of a cross-team module should be in charge I would think? Happy to change it to whoever is best if I chose the wrong teams

[kpethtel]

Couple of small suggestions about the specs, but this looks good. IDK how i got away without making the codeowners change. Maybe they tightened up the CI after I did this.

[kpethtel]

I would suggest making two changes:

• I think this should go in spec/sidekiq/schema_contract/delete_validation_records_job_spec.rb. Doing this will unfortunately be another addition to the codeowners file.
• rather than check for a change in the records count, I would explicitly check after the perform to ensure that the remaining record is the one we want.

[Tonksthebear]

Good point. I was avoiding making a new file but you're right, it should be done properly. I made the changes

[va-vsp-bot]

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/sidekiq/schema_contract/delete_validation_records_job_spec.rb

[kpethtel]

Thanks for creating the new spec file.

[kpethtel]

I would generally recommend using let over ivars in rspec. For a case like this, you could use let! to achieve the same effect as a before block.

[Tonksthebear]

Ah, didn't know let! would do what I wanted. I did let and it didn't work, so TIL. Changed!

[kpethtel]

👍