Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Benefits-Team-1 from CODEOWNERS #16789

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anniebtran
Copy link
Contributor

@anniebtran anniebtran commented May 16, 2024

Summary

Removes Benefits-Team-1 from CODEOWNERS because that team no longer exists / there are more specific teams now.

Related issue(s)

department-of-veterans-affairs/va.gov-team#66191

Requested Feedback

If there are any teams that we know should be added in place of the removed team, let me know!

Copy link

1 Warning
⚠️ This PR changes 236 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • .github/CODEOWNERS (+118/-118)

Note: We exclude files matching the following when considering PR size:

*.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to DR-clean-up-BenefitsTeam1-codeowner/main/main May 16, 2024 22:49 Inactive
@anniebtran anniebtran marked this pull request as ready for review May 17, 2024 14:12
@anniebtran anniebtran requested a review from a team as a code owner May 17, 2024 14:12
@tblackwe tblackwe requested a review from a team as a code owner May 17, 2024 15:01
@va-vfs-bot va-vfs-bot temporarily deployed to DR-clean-up-BenefitsTeam1-codeowner/main/main May 17, 2024 15:14 Inactive
@tblackwe tblackwe force-pushed the DR-clean-up-BenefitsTeam1-codeowner branch from 2a5a51e to d94223b Compare May 17, 2024 16:00
@tblackwe tblackwe removed the request for review from a team May 17, 2024 16:01
rjohnson2011
rjohnson2011 previously approved these changes May 17, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to DR-clean-up-BenefitsTeam1-codeowner/main/main May 17, 2024 17:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants