Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8441: remove references to transitioned facility #16792

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

kpethtel
Copy link
Contributor

Summary

Facility 556 has completed its transition to cerner. We should remove references to

Related issue(s)

department-of-veterans-affairs/va-mobile-app#8441

Testing done

Specs.

Screenshots

Note: Optional

What areas of the site does it impact?

Disables feature for the transitioned facility. This has no real world impact because the feature is already turned off on the front end.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

Copy link
Contributor

@Tonksthebear Tonksthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpethtel kpethtel merged commit 11c7135 into master May 20, 2024
19 checks passed
@kpethtel kpethtel deleted the 8441-remove-id branch May 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants