Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 36429 special issues form526 #16796

Merged
merged 2 commits into from
May 20, 2024

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): NO
  • Adjust EVSS docker mapping logic to accommodate the potential submission of special issues via form submission, in addition to existing handling for PACT special issues.
  • Adds tests to exercise mapping logic.

Related issue(s)

API-36429

Testing done

  • New code is covered by unit tests
  • Tested locally using Postman to confirm updates do not break existing logic for 526 submissions.
  • rspec

What areas of the site does it impact?

Affects EVSS docker container mapping logic for disabilities, specifically handling of special issues.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added the claimsApi modules/claims_api label May 17, 2024
@mchristiansonVA mchristiansonVA self-assigned this May 17, 2024
@mchristiansonVA mchristiansonVA requested a review from a team as a code owner May 17, 2024 19:56
Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appeared to map that still as expected, so LGTM!

Screenshot 2024-05-17 at 3 42 23 PM

@mchristiansonVA mchristiansonVA merged commit 40d6e55 into master May 20, 2024
20 checks passed
@mchristiansonVA mchristiansonVA deleted the API-36429-special-issues-form526 branch May 20, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants