Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[78745] Create accreditation model #16799

Merged
merged 2 commits into from
May 20, 2024
Merged

[78745] Create accreditation model #16799

merged 2 commits into from
May 20, 2024

Conversation

jvcAdHoc
Copy link
Contributor

@jvcAdHoc jvcAdHoc commented May 17, 2024 •
edited

Summary

  • This pr adds a new Accreditation model that acts the join between AccreditedIndividual and AccreditedOrganization

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Tested creattion with factories in rails console
  • Tested destroy with rails console

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@jvcAdHoc jvcAdHoc added find-a-representative Benefits Representation Management product label appoint-a-representative Benefits Representation Management product label labels May 17, 2024
@jvcAdHoc jvcAdHoc self-assigned this May 17, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to 78745-create-accreditations-model/main/main May 17, 2024 21:45 Inactive
@jvcAdHoc jvcAdHoc force-pushed the 78745-create-accreditations-model branch from fb8e685 to 896e6a5 Compare May 20, 2024 14:44
@va-vfs-bot va-vfs-bot temporarily deployed to 78745-create-accreditations-model/main/main May 20, 2024 14:54 Inactive
@jvcAdHoc jvcAdHoc force-pushed the 78745-create-accreditations-model branch from 896e6a5 to 65769d8 Compare May 20, 2024 15:26
@jvcAdHoc jvcAdHoc force-pushed the 78745-create-accreditations-model branch from 65769d8 to 7f9955e Compare May 20, 2024 15:28
@va-vfs-bot va-vfs-bot temporarily deployed to 78745-create-accreditations-model/main/main May 20, 2024 15:33 Inactive
@jvcAdHoc jvcAdHoc marked this pull request as ready for review May 20, 2024 15:49
@jvcAdHoc jvcAdHoc requested review from a team as code owners May 20, 2024 15:49
@rjohnson2011 rjohnson2011 merged commit 774dd73 into master May 20, 2024
19 checks passed
@rjohnson2011 rjohnson2011 deleted the 78745-create-accreditations-model branch May 20, 2024 17:10
gabezurita
gabezurita reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@gabezurita gabezurita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

app/models/accredited_individual.rb
# POA codes of the AccreditedOrganizations they are accredited with.
# 4. Attorneys and claims agents should have a POA code and should not be accredited with any AccreditedOrganization
# 5. The ogc_id is the id from the source table within OGC. It can be used to interact with their show endpoints
# and may be nice to have for troubleshooting purposes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving this documentation @jvcAdHoc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabezurita gabezurita gabezurita left review comments

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

Assignees

@jvcAdHoc jvcAdHoc

Labels
appoint-a-representative Benefits Representation Management product label find-a-representative Benefits Representation Management product label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jvcAdHoc @gabezurita @rjohnson2011 @va-vfs-bot