Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBEX: assign toxic exposure submit endpoint & metadata #16802

Merged

Conversation

freeheeling
Copy link
Contributor

@freeheeling freeheeling commented May 17, 2024

Summary

  • This work is behind a feature toggle (flipper): YES/NO: disability_526_toxic_exposure
  • Evaluates Flipper set for current user, assigning boolean value of a includeToxicExposure metadata attribute for a newly created in progress form, to be utilized on the frontend in tracking and reporting the inclusion of the toxic exposure section for the form
  • A submission whose submit_endpoint attribute is set to 'claims_api' (implemented in previous PR update) is handled similarly to that of a user whose disability_compensation_lighthouse_submit_migration Flipper is enabled
  • Conditionally sets options argument based on disability_526_toxic_exposure Flipper state for the current user, determining ultimate Lighthouse API submit endpoint ('/526' or '/526/generatePDF')
  • Responsible team: Disability Benefits Experience Team 2 (dBeX Carbs 馃)

Related issue(s)

Testing done

  • unit test enablement of toxic exposure feature flag
  • local data manipulated to confirm expected results
  • plan to target staging users for additional verification

What areas of the site does it impact?

  • Form 526EZ

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable)
  • Neither error nor warning in the console
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@freeheeling freeheeling added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels May 17, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/81830-toxic-exposure-metadata-and-endpoint-assignment/main/main May 18, 2024 00:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/81830-toxic-exposure-metadata-and-endpoint-assignment/main/main May 18, 2024 00:40 Inactive
@freeheeling freeheeling force-pushed the dbex/81830-toxic-exposure-metadata-and-endpoint-assignment branch from 60ccb85 to 735f181 Compare May 20, 2024 19:40
@freeheeling freeheeling force-pushed the dbex/81830-toxic-exposure-metadata-and-endpoint-assignment branch from 735f181 to c245cc0 Compare May 20, 2024 19:42
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/81830-toxic-exposure-metadata-and-endpoint-assignment/main/main May 20, 2024 20:39 Inactive
@freeheeling freeheeling force-pushed the dbex/81830-toxic-exposure-metadata-and-endpoint-assignment branch from 4a4ebd7 to 49ae5a2 Compare May 20, 2024 21:11
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/81830-toxic-exposure-metadata-and-endpoint-assignment/main/main May 20, 2024 21:47 Inactive
# submit 526 through LH API
# 1. get user's ICN
user_account = UserAccount.find_by(id: submission.user_account_id) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 馃槒

@freeheeling freeheeling marked this pull request as ready for review May 20, 2024 23:26
@freeheeling freeheeling requested review from a team as code owners May 20, 2024 23:26
@freeheeling freeheeling merged commit 508052d into master May 21, 2024
19 checks passed
@freeheeling freeheeling deleted the dbex/81830-toxic-exposure-metadata-and-endpoint-assignment branch May 21, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants