Upgrade webpack manifest plugin #18052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodur
commented
Jul 29, 2021
| fileName: 'file-manifest.json', | ||
| filter: ({ path: filePath }) => !filePath.includes('/generated/..'), | ||
| filter: ({ isChunk }) => isChunk, |
There was a problem hiding this comment.
Our old filtering wasn't excluding fonts and svgs after upgrading the plugin for some reason. The mappings for those are still correct, but since we don't need them in the manifest, I updated this to exclude them.
va-vfs-bot
temporarily deployed
to
master/upgrade-webpack-manifest-plugin/master
U-DON
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v2.2.0 of the
webpack-manifest-pluginhas a bug that causes inaccurate mappings to fonts and images (more context). This PR upgrades the plugin to the latest version4.0.1.Original issue(s)
department-of-veterans-affairs/va.gov-team#18317
Testing done
Compared
file-manifest.jsonbefore and after upgrade for each build type. Confirmed that everything is present in the manifest after the upgrade except for the unwanted.scssand font mappings.Screenshots
Acceptance criteria
file-manifest.jsonshould contain the same data as before the upgrade, except for.scsssmappings to fonts.Definition of done