upgrade react-router-dom dependency #18762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k80bowman
approved these changes
Sep 16, 2021
va-vfs-bot
temporarily deployed
to
master/upgrade-react-router-dom/master
…fairs/vets-website into upgrade-react-router-dom
va-vfs-bot
temporarily deployed
to
master/upgrade-react-router-dom/master
va-vfs-bot
temporarily deployed
to
master/upgrade-react-router-dom/master
va-vfs-bot
temporarily deployed
to
master/upgrade-react-router-dom/master
jbalboni
reviewed
Sep 17, 2021
| userEvent.click(screen.getByText(/View your appointments/i)); | ||
| expect(screen.history.push.called).to.be.true; | ||
| expect(screen.history.push.getCall(0).args[0]).to.equal('/'); | ||
| expect(screen.getByText(/View your appointments/i)).to.have.attribute( |
There was a problem hiding this comment.
These tests were breaking due to remix-run/react-router#5362
For the tests that were breaking, we were rendering a page outside of our normal route structure, so the url of the page being tested wasn't the actual url, it was just /. This means that some of our links back to the homepage looked to react-router like we were going from / to /, which now doesn't generate a history push. We were testing the link clicks by looking for a push.
Instead, I've updated them to just look at the href and not click when we don't care about switching to another page, and looking for a history replace when we do care about the next page.
jbalboni
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor upgrade. No breaking changes.
Original issue(s)
department-of-veterans-affairs/va.gov-team#28952
Testing done
Locally
Screenshots
Acceptance criteria
Definition of done