special/bin: climb up directories to find binary module (#437)

* special/bin: climb up directories to find binary module

Issue #436

* Move .gitignore to upper directory

* Remove duplicate test

* Add test for binary packages in parent directories

src/index.js

@@ -21,7 +21,9 @@ function hasBin(rootDir, dependency) {
     const metadata = readJSON(path.join(rootDir, 'node_modules', dependency, 'package.json'));
     return {}.hasOwnProperty.call(metadata, 'bin');
   } catch (error) {
-    return false;
+    return rootDir === path.parse(rootDir).root
+      ? false
+      : hasBin(path.dirname(rootDir), dependency);
   }
 }
 

src/special/bin.js

@@ -19,7 +19,9 @@ function loadMetadata(dep, dir) {
     const packagePath = path.resolve(dir, 'node_modules', dep, 'package.json');
     return getCacheOrRequire(packagePath);
   } catch (error) {
-    return {}; // ignore silently
+    return dir === path.parse(dir).root
+      ? {} // ignore silently
+      : loadMetadata(dep, path.dirname(dir));
   }
 }
 

test/fake_modules/bin_js/package.json

@@ -1,5 +1,6 @@
 {
   "dependencies": {
-    "anybin": "*"
+    "anybin": "*",
+    "upperbin": "*"
   }
 }

test/spec.js

@@ -477,7 +477,7 @@ export default [
       ignoreBinPackage: false,
     },
     expected: {
-      dependencies: ['anybin'],
+      dependencies: ['anybin', 'upperbin'],
       devDependencies: [],
       missing: {},
       using: {},
@@ -499,19 +499,6 @@ export default [
       },
     },
   },
-  {
-    name: 'not ignore bin dependencies when ignoreBinPackage is false',
-    module: 'bin_js',
-    options: {
-      ignoreBinPackage: false,
-    },
-    expected: {
-      dependencies: ['anybin'],
-      devDependencies: [],
-      missing: {},
-      using: {},
-    },
-  },
   {
     name: 'output empty missing dependencies when skipMissing is true',
     module: 'missing',

test/special/bin.js

@@ -5,11 +5,23 @@ import parse from '../../src/special/bin';
 
 const testCases = [
   {
-    name: 'detect packages used in scripts',
+    name: 'detect packages used in scripts in local directory',
     script: 'binary-entry --argument',
     dependencies: ['binary-package'],
     expected: ['binary-package'],
   },
+  {
+    name: 'detect packages used in scripts in parent directory',
+    script: 'binupper --upperarg',
+    dependencies: ['upperbin'],
+    expected: ['upperbin'],
+  },
+  {
+    name: 'detect packages used in scripts (anywhere)',
+    script: 'binary-entry --argument || binupper --upperarg',
+    dependencies: ['binary-package', 'upperbin'],
+    expected: ['binary-package', 'upperbin'],
+  },
   {
     name: 'detect packages used as `.bin` path',
     script: './node_modules/.bin/binary-entry',
@@ -49,13 +61,13 @@ const testCases = [
   {
     name: 'not report it when it is not used',
     script: 'other-binary-entry',
-    dependencies: ['binary-package'],
+    dependencies: ['binary-package', 'upperbin'],
     expected: [],
   },
   {
     name: 'ignore detection when no scripts section',
     script: false,
-    dependencies: ['binary-package'],
+    dependencies: ['binary-package', 'upperbin'],
     expected: [],
   },
   {