Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Typescript webpack files #246

Closed
cbrianball opened this issue Feb 26, 2018 · 9 comments
Closed

Support for Typescript webpack files #246

cbrianball opened this issue Feb 26, 2018 · 9 comments
Labels

Comments

@cbrianball
Copy link

It looks like the webpack special only works if the webpack config file is a .js file. I use .ts files for my webpack configuration.

@lijunle
Copy link
Member

lijunle commented Feb 28, 2018 via email

@sveyret
Copy link
Contributor

sveyret commented Nov 1, 2019

FI, I'm currently working on this…

rumpl pushed a commit that referenced this issue Nov 1, 2019
* special/webpack: Manage TypeScript webpack definition

Issue #246

* special/webpack: Scan webpack entries for dependencies

Issue #446

* special/webpack: Detect babel-loader presets

Issue #448
@rumpl rumpl closed this as completed Nov 1, 2019
@rumpl
Copy link
Member

rumpl commented Nov 1, 2019

Closed with #449

@sveyret
Copy link
Contributor

sveyret commented Nov 1, 2019

Should we re-open this one because of the ts-node requisite? Or simply add a comment in any document?

@rumpl
Copy link
Member

rumpl commented Nov 1, 2019

Yeah, I'll reopen it, so that I don't search why:

The regex for webpack configuration was changed to accept .ts files but we can only require this kind of file if depcheck is used as a library with a ts-node runtime.

For this to trully work we need a way to be able to load .ts configuration files. This will surely mean that we need to depend on typescript directly, which I don't mind that much.

@rumpl rumpl reopened this Nov 1, 2019
@sveyret
Copy link
Contributor

sveyret commented Nov 2, 2019

@rumpl did you receive my e-mail? I sent it to you GMail account from a personal server, and I know that GMail is sometimes touchy about personal servers, and so may put e-mails in spams.

@rumpl
Copy link
Member

rumpl commented Nov 2, 2019

Just saw it, the email I have on github is an email that I don't look every day, will respond today, have to clean up my appartment now :)

@sveyret
Copy link
Contributor

sveyret commented Nov 9, 2019

PR #459 now should fully correct the issue. @rumpl, I think it can be closed.

@stale
Copy link

stale bot commented Mar 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants