Load typescript transpiler if available #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
==========================================
+ Coverage 99.19% 99.21% +0.01%
==========================================
Files 39 39
Lines 749 761 +12
==========================================
+ Hits 743 755 +12
Misses 6 6
Continue to review full report at Codecov.
|
|
Adding the typescript dependency removed all the optional keys from the |
|
Not a problem no |
I think this depend of the npm version you use |
rumpl
reviewed
Nov 3, 2019
package.json
Outdated
| @@ -16,8 +16,8 @@ | |||
| "scripts": { | |||
| "component": "node -r @babel/register ./build/component.js > ./dist/component.json", | |||
| "compile": "babel src/ -d dist/", | |||
| "depcheck": "node ./bin/depcheck.js --ignore-dirs=fake_modules", | |||
There was a problem hiding this comment.
We have a nifty file for this, you can even add a comment as to why you are adding the import
rumpl
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the require of the webpack configuration file, even in TypeScript, without the need to run depcheck with ts-node. This needs that depcheck can find the typescript dependency, either directly in the scanned project, in the current directory, or in the directory of depcheck.
Issue #246