New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript to 5.3.3 #815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change to ^4.9.0
or ^4.9.5
instead.
But better to ^4.9.0
since that is the required version.
TypeScript 5 may break some type definitions.
package.json
Outdated
@@ -101,7 +101,7 @@ | |||
"proxyquire": "^2.1.3", | |||
"should": "^13.2.3", | |||
"svelte": "^3.38.2", | |||
"typescript": "^4.0.5" | |||
"typescript": "^5.1.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use ^4.9.0
instead.
Required for what?
Can you be more specific please? |
5edd6da
to
4e0941a
Compare
I think the tool should generally try to update its dependencies continuously to their latest version. Here, if there is no test broken, we can assume that there is no breaking change and can move forward. If we want to document a particular behavior and prevent against breaking changes, we should ideally have that covered with a test. |
4e0941a
to
d5c5f67
Compare
d5c5f67
to
6078fab
Compare
May fix #814