Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript to 5.3.3 #815

Merged
merged 2 commits into from Jan 11, 2024
Merged

Update typescript to 5.3.3 #815

merged 2 commits into from Jan 11, 2024

Conversation

znarf
Copy link
Collaborator

@znarf znarf commented Jun 29, 2023

May fix #814

Copy link

@vivi90 vivi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to ^4.9.0 or ^4.9.5 instead.
But better to ^4.9.0 since that is the required version.
TypeScript 5 may break some type definitions.

package.json Outdated
@@ -101,7 +101,7 @@
"proxyquire": "^2.1.3",
"should": "^13.2.3",
"svelte": "^3.38.2",
"typescript": "^4.0.5"
"typescript": "^5.1.6"
Copy link

@vivi90 vivi90 Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ^4.9.0 instead.

@rumpl
Copy link
Member

rumpl commented Jul 17, 2023

But better to ^4.9.0 since that is the required version.

Required for what?

TypeScript 5 may break some type definitions.

Can you be more specific please?

@znarf znarf changed the title Update typescript to 5.1.6 Update typescript to 5.3.2 Nov 20, 2023
@znarf
Copy link
Collaborator Author

znarf commented Nov 23, 2023

I think the tool should generally try to update its dependencies continuously to their latest version.

Here, if there is no test broken, we can assume that there is no breaking change and can move forward.

If we want to document a particular behavior and prevent against breaking changes, we should ideally have that covered with a test.

@znarf znarf changed the title Update typescript to 5.3.2 Update typescript to 5.3.3 Jan 11, 2024
@rumpl rumpl merged commit 0dbe981 into main Jan 11, 2024
3 checks passed
@rumpl rumpl deleted the typescript-update branch January 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Webpack: False alerts with TypeScript >= 4.9
3 participants