fix: Handle array extends in tsconfig #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znarf
requested changes
Nov 23, 2023
src/parser/tsconfig.js
Outdated
| @@ -22,7 +22,11 @@ export default function tsconfigParser(filePath, deps) { | |||
| }); | |||
| } | |||
| if (tsconfigJson.extends) { | |||
| foundDeps.push(tsconfigJson.extends); | |||
| if Array.isArray(tsconfigJson.extends) { | |||
There was a problem hiding this comment.
It's not valid JS and tests are failing.
There was a problem hiding this comment.
Yes, sorry. Shouldn't have tried to just edit from Github.
|
@znarf Would you prefer a separate test or just to add another file to the tsconfig test (I believe that should work)? |
|
@alexeyr-ci doesn't matter, whatever proves that this is doing the job. Adding a test to the tsconfig test file sounds good. |
alexeyr-ci
force-pushed
the
patch-1
branch
4 times, most recently
from
14d41f0
to
ea7e197
Compare
|
@znarf This should work, I believe, and CI passes. |
|
Unfortunately there are conflicts now, @alexeyr-ci would you be so kind and rebase this so I can merge? |
|
@rumpl Rebased. |
rumpl
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #854