Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump npm from 7.10.0 to 7.19.1 #4052

Merged
merged 2 commits into from Jul 15, 2021
Merged

Bump npm from 7.10.0 to 7.19.1 #4052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bdd24a7
Bump npm from 7.10.0 to 7.19.1
feelepxyz Jul 15, 2021
30000a7
Fix lockfile from to match package.json dep requirement
feelepxyz Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions Dockerfile
View file
Open in desktop
Expand Up @@ -97,14 +97,11 @@ USER root

### JAVASCRIPT

# Install Node 14.0 and npm (updated after elm)
# Install Node 14.0 and npm v7
RUN curl -sL https://deb.nodesource.com/setup_14.x | bash - \
&& apt-get install -y --no-install-recommends nodejs \
&& rm -rf /var/lib/apt/lists/*

# NOTE: This was a hack to get around the fact that elm 18 failed to install with
# npm 7, we should look into installing the latest version of node + npm
RUN npm install -g npm@v7.10.0 \
&& rm -rf /var/lib/apt/lists/* \
&& npm install -g npm@v7.19.1 \
&& rm -rf ~/.npm


Expand Down
2 changes: 1 addition & 1 deletion npm_and_yarn/spec/dependabot/npm_and_yarn/file_updater_spec.rb
View file
Open in desktop
Expand Up @@ -2518,7 +2518,7 @@
to eq("git+ssh://git@github.com/jonschlinkert/is-number.git#"\
"0c6b15a88bc10cd47f67a09506399dfc9ddc075d")
expect(parsed_package_lock["dependencies"]["is-number"]["from"]).
to eq("is-number@github:jonschlinkert/is-number#semver:^4.0.0")
to eq("is-number@jonschlinkert/is-number#semver:^4.0.0")
Copy link
Contributor Author

@feelepxyz feelepxyz Jul 15, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like npm fixed an issue here, this new from now mirrors the syntax in package.json dependency requirement

dependabot-core/npm_and_yarn/spec/fixtures/projects/npm7/github_dependency_semver_modern/package.json

Line 20 in e5faa79

"is-number": "jonschlinkert/is-number#semver:^2.0.0"

end
end
end
Expand Down